feat(cli): load plugin configs from plugin.toml - #93
Merged
rapids-bot[bot] merged 7 commits intoMay 13, 2026
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Details
Summary
This PR wires the CLI gateway to the generic NeMo Flow plugin configuration path and adds a dedicated
plugin.tomlfile option for process-level plugin activation.The gateway now resolves a single
PluginConfigfrom supported configuration sources, activates it when the server starts, and clears it when the server shuts down. The implementation is generic over plugin kind; the tests exercise the observability plugin today while keeping the config path usable for future plugin kinds such as adaptive once those plugins are registered in the CLI process.Changes
--plugin-config/NEMO_FLOW_PLUGIN_CONFIGsupport.plugin.tomldiscovery and loading for root-level genericPluginConfigTOML.plugin.tomlalongside explicit--config path/to/config.toml.plugin.tomlfiles from system, nearest project, and user scopes.plugin.toml,[plugins].config, and--plugin-config.[plugins].configsupport inconfig.toml.plugin.tomlshape for observability plugin configuration.Validation
cargo fmt --check cargo test -p nemo-flow-cli cargo build -p nemo-flow-cliNotes
plugin.tomluses the generic plugin config shape at the file root:Where should the reviewer start?
Start with
crates/cli/src/config.rs. The key design decision is that the CLI still resolves exactly one genericPluginConfig, but that config may now come from--plugin-config,[plugins].config, orplugin.toml. The conflict checks in that file are the main behavior to review.Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
Summary by CodeRabbit
New Features
Bug Fixes
Documentation
Tests